revamps SSoT cookie for contrib pattern #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Outgoing syncs can't really use contrib as we want to model the diffsync models after the destination system, so the direction toggle makes a lot of sense. |
- collapses both adapters into one file, asthe Nautobot adapter is significantly simpler with contrib collapse all models into one class per Nautobot content type -> users are of course free to change this but I found that for most SSoTs this is unnecessary complexity - the differentation between base, SoR and Nautobot seems not necessary because SSoTs that sync both way simply don't exist - add a "direction_of_sync" cookiecutter variable to define whether contrib classes are used or not depending on direction of sync
Kircheneer
force-pushed
the
ssot-cookie-revamp
branch
from
127f1d9 to
87f48e8
Compare
jdrew82
previously approved these changes
Dec 16, 2024
...obot-app-ssot/{{ cookiecutter.project_slug }}/{{ cookiecutter.app_name }}/diffsync/models.py
Outdated
Show resolved
Hide resolved
|
Looking good. I am unable to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have revamped the SSoT cookie to match the new
nautobot_ssot.contribpattern. As such, I have also simplified the folder layout:TODO
create,update, anddeletemethods of the model and adding a question to.cookiecutter.jsonfor the direction of the snyc